Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimal reconnect period #12639

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Update minimal reconnect period #12639

merged 1 commit into from
Jul 3, 2023

Conversation

AlbumenJ
Copy link
Member

@AlbumenJ AlbumenJ commented Jul 1, 2023

What is the purpose of the change

Set minimal reconnect period as 60s even heartbeat is smaller than 60s

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #12639 (0b6d205) into 3.2 (70a948a) will decrease coverage by 0.59%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #12639      +/-   ##
============================================
- Coverage     69.93%   69.35%   -0.59%     
+ Complexity      315        2     -313     
============================================
  Files          1852     1629     -223     
  Lines         97719    67378   -30341     
  Branches      17847     9882    -7965     
============================================
- Hits          68343    46732   -21611     
+ Misses        23900    16128    -7772     
+ Partials       5476     4518     -958     

see 3481 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@EarthChen EarthChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EarthChen EarthChen merged commit 271d5ef into apache:3.2 Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants