-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize code in DubboSpringInitializer #12834
Optimize code in DubboSpringInitializer #12834
Conversation
Codecov Report
@@ Coverage Diff @@
## 3.2 #12834 +/- ##
============================================
+ Coverage 69.43% 69.48% +0.04%
Complexity 2 2
============================================
Files 1647 1648 +1
Lines 68347 68354 +7
Branches 9984 9986 +2
============================================
+ Hits 47457 47495 +38
+ Misses 16306 16287 -19
+ Partials 4584 4572 -12 see 33 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
) { | ||
DubboSpringInitContext context = contextMap.remove(entry.getKey()); | ||
logger.info("Unbind " + safeGetModelDesc(context.getModuleModel()) + " from spring container: " + | ||
logger.info("Unbind " + context.getModuleModel().getDesc() + " from spring container: " + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible throws NPE here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible throws NPE here?
The initContext method ensures that the context.getModuleMode() method does not return null.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove before init may erorr?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove before init may erorr?
right.
69283d3
to
389d762
Compare
Kudos, SonarCloud Quality Gate passed! |
What is the purpose of the change
Optimize code in DubboSpringInitializer
Brief changelog
Verifying this change
Checklist