Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize code in DubboSpringInitializer #12834

Merged

Conversation

kang-hl
Copy link
Contributor

@kang-hl kang-hl commented Aug 3, 2023

What is the purpose of the change

Optimize code in DubboSpringInitializer

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2023

Codecov Report

Merging #12834 (389d762) into 3.2 (757643c) will increase coverage by 0.04%.
Report is 3 commits behind head on 3.2.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #12834      +/-   ##
============================================
+ Coverage     69.43%   69.48%   +0.04%     
  Complexity        2        2              
============================================
  Files          1647     1648       +1     
  Lines         68347    68354       +7     
  Branches       9984     9986       +2     
============================================
+ Hits          47457    47495      +38     
+ Misses        16306    16287      -19     
+ Partials       4584     4572      -12     

see 33 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

) {
DubboSpringInitContext context = contextMap.remove(entry.getKey());
logger.info("Unbind " + safeGetModelDesc(context.getModuleModel()) + " from spring container: " +
logger.info("Unbind " + context.getModuleModel().getDesc() + " from spring container: " +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible throws NPE here?

Copy link
Contributor Author

@kang-hl kang-hl Aug 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible throws NPE here?

The initContext method ensures that the context.getModuleMode() method does not return null.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove before init may erorr?

Copy link
Contributor Author

@kang-hl kang-hl Aug 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove before init may erorr?

right.

@kang-hl kang-hl force-pushed the optimize-code-in-DubboSpringInitializer branch from 69283d3 to 389d762 Compare August 9, 2023 08:32
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

91.7% 91.7% Coverage
0.0% 0.0% Duplication

@AlbumenJ AlbumenJ merged commit 45405ff into apache:3.2 Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants