Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix chunkoutputstream chunksize exception #12926

Merged
merged 1 commit into from
Aug 22, 2023
Merged

fix chunkoutputstream chunksize exception #12926

merged 1 commit into from
Aug 22, 2023

Conversation

suncairong163
Copy link
Contributor

What is the purpose of the change

#12891
fix chunkoutputstream chunksize exception

Brief changelog

Verifying this change

@CrazyHZM

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

82.4% 82.4% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #12926 (254005f) into 3.2 (6b617a1) will decrease coverage by 0.60%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #12926      +/-   ##
============================================
- Coverage     70.06%   69.47%   -0.60%     
+ Complexity      339        2     -337     
============================================
  Files          1875     1648     -227     
  Lines         99207    68407   -30800     
  Branches      18069     9993    -8076     
============================================
- Hits          69507    47524   -21983     
+ Misses        24194    16296    -7898     
+ Partials       5506     4587     -919     

see 3523 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@CrazyHZM PTAL

@CrazyHZM CrazyHZM merged commit 8068c99 into apache:3.2 Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants