Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nullpoint problem when channel inactive #13062

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

finefuture
Copy link
Contributor

What is the purpose of the change

image

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@finefuture
Copy link
Contributor Author

image
@AlbumenJ common test failure

@finefuture finefuture changed the title Fix concurrency problem when receive ResetFrame and HeaderFrame Fix nullpoint problem when channel inactive Sep 18, 2023
@apache apache deleted a comment from imhuzi Sep 19, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #13062 (ddfe357) into 3.2 (139a62e) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #13062      +/-   ##
============================================
- Coverage     69.43%   69.41%   -0.02%     
  Complexity        2        2              
============================================
  Files          1649     1649              
  Lines         68566    68568       +2     
  Branches      10001    10002       +1     
============================================
- Hits          47607    47595      -12     
- Misses        16368    16381      +13     
- Partials       4591     4592       +1     

see 32 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@finefuture
Copy link
Contributor Author

image
When channel was inactive, it would dispatch ResetFrame without init resource.

@AlbumenJ
Copy link
Member

@EarthChen PTAL

Copy link
Member

@EarthChen EarthChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EarthChen EarthChen merged commit 2697652 into apache:3.2 Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants