Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order dependent tests in InternalThreadLocalTest #13361

Conversation

SaaiVenkat
Copy link
Contributor

What is the purpose of the change

  • In dubbo-common, several test cases in the test class dubbo-common,org.apache.dubbo.common.threadlocal.InternalThreadLocalTest.java can trigger java.lang.ClassCastException, when being run after the unit test in testConstructionWithIndex() in the same class because it pollutes state shared among tests.
  • It may be good to clean this state pollution so that some other tests do not fail in the future due to the shared state polluted by this test.

Issue Link: DUBBO-13359

Brief changelog

  • Changed nextIndex.get() to nextIndex.incrementAndGet() in InternalThreadLocalTest.java to properly restore the polluted state InternalThreadLocalMap.NEXT_INDEX

Verifying this change

  • With the proposed fix, the test does not pollute the shared state.
  • All the tests pass when run in the any order.

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7c3e592) 69.56% compared to head (cca16af) 69.55%.

Additional details and impacted files
@@             Coverage Diff              @@
##                3.2   #13361      +/-   ##
============================================
- Coverage     69.56%   69.55%   -0.02%     
  Complexity        2        2              
============================================
  Files          1652     1652              
  Lines         71608    71608              
  Branches      10264    10264              
============================================
- Hits          49813    49804       -9     
  Misses        17102    17102              
- Partials       4693     4702       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlbumenJ AlbumenJ merged commit 27e9877 into apache:3.2 Nov 15, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants