Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dubbo monitor module #13456

Merged
merged 8 commits into from
Dec 18, 2023
Merged

Remove dubbo monitor module #13456

merged 8 commits into from
Dec 18, 2023

Conversation

CrazyHZM
Copy link
Member

@CrazyHZM CrazyHZM commented Dec 4, 2023

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Signed-off-by: crazyhzm <crazyhzm@gmail.com>
@CrazyHZM CrazyHZM force-pushed the feat/remove_monitor branch from 08489a1 to 29735e3 Compare December 4, 2023 09:36
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

21 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3f48269) 40.43% compared to head (b063de4) 35.99%.
Report is 69 commits behind head on 3.3.

Additional details and impacted files
@@            Coverage Diff             @@
##              3.3   #13456      +/-   ##
==========================================
- Coverage   40.43%   35.99%   -4.44%     
==========================================
  Files        1808     1757      -51     
  Lines       75893    73989    -1904     
  Branches    10642    10444     -198     
==========================================
- Hits        30687    26635    -4052     
- Misses      40886    43356    +2470     
+ Partials     4320     3998     -322     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CrazyHZM CrazyHZM merged commit 5b0b86b into apache:3.3 Dec 18, 2023
13 checks passed
@CrazyHZM CrazyHZM deleted the feat/remove_monitor branch December 18, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants