Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task #13958 Move Rest Protocol to SPI Extensions #14061

Merged
merged 15 commits into from
May 10, 2024
Merged

Conversation

wcy666103
Copy link
Contributor

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@wcy666103
Copy link
Contributor Author

wcy666103 commented Apr 11, 2024

There are three things to note:

  1. I deleted rest related classes from dubbo-compatible module because they are hard dependencies
  2. The dubbo-plugin/dubbo-rest-jaxrs module and the test case in the dubbo-rest-spring module are all annotated with disable. Consider moving to apache/dubbo-integration-cases , as they are compatibility tests
  3. The dubbo - config - spring module under ControllerServiceConfigTest was disable comments, because it is specifically for rest Protocol test cases, considered to be deleted or changed

What should I do about these problems?

@wcy666103
Copy link
Contributor Author

After discussion, it is appropriate to move these three tests to apache/dubbo-integration-cases. Thanks for your help @oxsean

@chickenlj
Copy link
Contributor

@wcy666103 Too many things are included in one single pull request, better only include one thing each time.

@wcy666103
Copy link
Contributor Author

@wcy666103 Too many things are included in one single pull request, better only include one thing each time.
Ok, I'll take them apart

@wcy666103
Copy link
Contributor Author

wcy666103 commented Apr 17, 2024

PTAL @chickenlj @songxiaosheng @AlbumenJ

@chickenlj chickenlj closed this Apr 22, 2024
@AlbumenJ AlbumenJ reopened this May 8, 2024
@songxiaosheng
Copy link
Member

please resolve conflicts

# Conflicts:
#	dubbo-remoting/dubbo-remoting-http/src/main/java/org/apache/dubbo/remoting/http/config/HttpClientConfig.java
#	dubbo-remoting/dubbo-remoting-http/src/main/java/org/apache/dubbo/remoting/http/restclient/OKHttpRestClient.java
Copy link

sonarqubecloud bot commented May 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@songxiaosheng songxiaosheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@songxiaosheng
Copy link
Member

@AlbumenJ dubbo-samples-test-13787 test failed ,help check

@AlbumenJ AlbumenJ merged commit d1c6e55 into apache:3.3 May 10, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants