[Dubbo-1510] dubbo monitor missing parameters #1407
Conversation
2. monitor interval can be override by outside setting
Codecov Report
@@ Coverage Diff @@
## master #1407 +/- ##
=========================================
- Coverage 33.01% 32.9% -0.12%
=========================================
Files 691 691
Lines 34624 34630 +6
Branches 6850 6850
=========================================
- Hits 11431 11394 -37
- Misses 21247 21288 +41
- Partials 1946 1948 +2
Continue to review full report at Codecov.
|
YoungHu
changed the title
| this.interval = interval; | ||
| } | ||
|
|
||
| public String getInterval(){ |
There was a problem hiding this comment.
no one call getInterval() direct, this is used for fastjson serialize, so it can be passed to URL
| @@ -92,6 +93,7 @@ public void send() { | |||
| long maxOutput = numbers[7]; | |||
| long maxElapsed = numbers[8]; | |||
| long maxConcurrent = numbers[9]; | |||
| String version = getUrl().getParameter(Constants.DEFAULT_PROTOCOL); | |||
There was a problem hiding this comment.
IMO, this variable is named protocol may be better.
There was a problem hiding this comment.
why DEFAULT_PROTOCOL is necessary to collect?
There was a problem hiding this comment.
DEFAULT_PROTOCOL value is dubbo, this code is to get dubbo version but not protocol name. dubbo now upgrade fast, for a team, different project may use different dubbo version(eg 2.5.3, 2.6.0, 2.6.1), IMO, monitor need to know each project's dubbo version, so we can decide how to process the monitor data.
There was a problem hiding this comment.
sounds a reasonable data to collect, let me think about it more.
| @@ -92,6 +93,7 @@ public void send() { | |||
| long maxOutput = numbers[7]; | |||
| long maxElapsed = numbers[8]; | |||
| long maxConcurrent = numbers[9]; | |||
| String version = getUrl().getParameter(Constants.DEFAULT_PROTOCOL); | |||
There was a problem hiding this comment.
why DEFAULT_PROTOCOL is necessary to collect?
2. monitor interval can be override by outside setting
fix #1510
What is the purpose of the change
groupversiondubboparametersBrief changelog
group,version,dubboparametersVerifying this change
XXXX