Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trim application name of old mapping content #14133

Merged
merged 3 commits into from
May 8, 2024

Conversation

zrlw
Copy link
Contributor

@zrlw zrlw commented Apr 26, 2024

What is the purpose of the change

Since config service is unreliable, it's getConfig method might return a string that is ended by a space character,
so this PR want to

  1. enhance ServiceNameMapping to avoid using untrimmed app names as mappedServices.
  2. enhance MetadataServiceNameMapping to avoid registering duplicated service name mapping metadata.
    see [Feature] enhance service name mapping #14132

Brief changelog

  1. trim and filter out empty app name at ServiceNameMapping#getAppNames, just like AbstractServiceNameMapping#parseServices.
  2. trim old app name before comparison at MetadataServiceNameMapping#map.

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link

@AlbumenJ AlbumenJ merged commit 8863604 into apache:3.2 May 8, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants