Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][3.3] Triple rest jaxrs ParamConverter support #14148

Merged
merged 10 commits into from
Jul 22, 2024

Conversation

fanlobu
Copy link
Contributor

@fanlobu fanlobu commented Apr 30, 2024

What is the purpose of the change

Triple rest jaxrs ParamConverter support,related: #14037

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@AlbumenJ
Copy link
Member

AlbumenJ commented May 8, 2024

@oxsean PTAL

@oxsean
Copy link
Collaborator

oxsean commented May 8, 2024

@fanlobu Is it ready for review?

@fanlobu
Copy link
Contributor Author

fanlobu commented May 9, 2024

@fanlobu Is it ready for review?

I think it is ok, I did some simple tests in local

Copy link
Collaborator

@oxsean oxsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need unit test for this.

@oxsean
Copy link
Collaborator

oxsean commented Jun 9, 2024

@fanlobu please resolve error-code-inspector error first, You need log with error code

@oxsean
Copy link
Collaborator

oxsean commented Jun 10, 2024

LGTM.

@fanlobu
Copy link
Contributor Author

fanlobu commented Jun 10, 2024

@fanlobu please resolve error-code-inspector error first, You need log with error code

Thanks for all the suggestions for my code changes, I've done all the changes, but CICDtest runs failed, I checked the logs but didn't find a solution. Does this test run fail have anything to do with my commit ?

@oxsean
Copy link
Collaborator

oxsean commented Jun 10, 2024

Looks like a timeout, you can make a small change, like an empty line or a comment, to trigger the CI again.

Copy link

@AlbumenJ AlbumenJ merged commit 1916666 into apache:3.3 Jul 22, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants