fix the signature error when using reflection to access the org.springframework.core.annotation.AnnotatedElementUtils#getMergedAnnotation method #14156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…springframework.core.annotation.AnnotatedElementUtils#getMergedAnnotation method Fix the problem,the method org.apache.dubbo.config.spring.util.AnnotationUtils#tryGetMergedAnnotation utilizes reflection to access org.springframework.core.annotation.AnnotatedElementUtils#getMergedAnnotation. However, there is a signature mismatch in the method's input parameters, which leads to an inability to retrieve the correct method. Consequently, this results in the failure to obtain the mergedAnnotation.
AlbumenJ
approved these changes
May 8, 2024
|
|
@AlbumenJ The method org.apache.dubbo.config.spring.util.AnnotationUtils#tryGetMergedAnnotation is a public method. Should I remove the parameters classValuesAsString and nestedAnnotationsAsMap which are not being used, in order to resolve issues reported by SonarCloud? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14104.
The Problem
The method
org.apache.dubbo.config.spring.util.AnnotationUtils#tryGetMergedAnnotationutilizes reflection to accessorg.springframework.core.annotation.AnnotatedElementUtils#getMergedAnnotation. However, there is a signature mismatch in the method's input parameters, which leads to an inability to retrieve the correct method. Consequently, this results in the failure to obtain the mergedAnnotation.What is the purpose of the change
It is recommended to fix this issue, as it will cause the passing of the
DubboReferenceannotation to become ineffective.Brief changelog
fix the signature error when using reflection to access the org.springframework.core.annotation.AnnotatedElementUtils#getMergedAnnotation method
Verifying this change
After the patch, it is possible to correctly obtain the
org.springframework.core.annotation.AnnotatedElementUtils#getMergedAnnotationmethod.Checklist