Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the decoding of generic http2 #14175

Merged
merged 9 commits into from
May 23, 2024

Conversation

finefuture
Copy link
Contributor

@finefuture finefuture commented May 11, 2024

What is the purpose of the change

When native http2 sends a request, it is possible to send 1-2 data frames:

  1. The data frame is sent together with the endStream identifier
  2. The data frame and endStream identifier are sent separately.

In the second case, when a data frame with the endStream identifier is received and the data is empty, the parameters will be set to null. Loss of parameters will cause the call to fail.

Receiving the end_stream flag means that the unary data stream is complete and can be decoded.

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@finefuture finefuture force-pushed the 3.3-fix-http2-decoder branch from 75d0518 to 0237f80 Compare May 11, 2024 08:17
@finefuture
Copy link
Contributor Author

@AlbumenJ The rest protocol has been migrated to the dubbo-spi-extension project.
image

@finefuture
Copy link
Contributor Author

@oxsean @icodening PTAL

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.80%. Comparing base (a12975a) to head (49bd9eb).
Report is 80 commits behind head on 3.3.

Additional details and impacted files
@@            Coverage Diff             @@
##              3.3   #14175      +/-   ##
==========================================
+ Coverage   38.55%   38.80%   +0.25%     
==========================================
  Files        1895     1730     -165     
  Lines       79272    75341    -3931     
  Branches    11528    11099     -429     
==========================================
- Hits        30560    29233    -1327     
+ Misses      44439    41969    -2470     
+ Partials     4273     4139     -134     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oxsean
Copy link
Collaborator

oxsean commented May 16, 2024

Can you provider a test case? or how to test it?

@finefuture
Copy link
Contributor Author

Can you provider a test case? or how to test it?

Okay, I will provider a demo later.

@finefuture
Copy link
Contributor Author

@oxsean
Copy link
Collaborator

oxsean commented May 21, 2024

LGTM.

Copy link
Contributor

@icodening icodening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlbumenJ AlbumenJ merged commit 935849f into apache:3.3 May 23, 2024
@finefuture
Copy link
Contributor Author

Native http2 does not support client stream and bi stream (streaming requests are not supported), so we only need to deal with unary and server streams, which means streaming responses are supported.

Receiving the end_stream flag means that the unary data stream is complete and can be decoded.

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants