[3.3] Fix triple rest http GET failed #14223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
oxsean
changed the title
|
|
I think you are right. I seem to be confused by another bug. Anyway 'HttpServerAfterUpgradeHandler' can be removed now, I will keep an eye on it. |
AlbumenJ
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
HTTP/1 upgrade caused GET request to failed
Case:
https://github.com/apache/dubbo-samples/blob/master/2-advanced/dubbo-samples-triple-rest/dubbo-samples-triple-rest-springmvc/src/test/java/org/apache/dubbo/rest/demo/test/ConsumerIT.java#L47
Expect 'Hello world' but respone empty body.
Root cause
HttpServerUpgradeHandler.java#L377 already support write response, HttpServerAfterUpgradeHandler duplicate writes cause incorrect GET results.
Brief changelog
Remove unnecessary HttpServerAfterUpgradeHandler