-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dubbo-RpcContext] Simplify check consumer side in RpcContext #1444
[Dubbo-RpcContext] Simplify check consumer side in RpcContext #1444
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1444 +/- ##
=========================================
+ Coverage 31.59% 31.6% +0.01%
=========================================
Files 682 682
Lines 33035 33015 -20
Branches 6592 6583 -9
=========================================
- Hits 10436 10435 -1
+ Misses 20748 20731 -17
+ Partials 1851 1849 -2
Continue to review full report at Codecov.
|
where is the usage of isProviderSide and isConsumerSide? |
Usually the commit is right. Is there some special situation happened? |
the isProviderSide and isConsumerSide seem not use in dubbo framework. just a api for user. |
It's depends on the side key in new implementation. we can also see other place in dubbo code to use side key to check is consumer side or not. |
I think SIDE_KEY is enough to determine provider or consumer. |
What is the purpose of the change
There is no need to compare address to confirm whether they are consumer or not in RpcContext.
the remote address comes from url and compare with url.
Brief changelog
RpcContext