Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MetadataV2.proto update #14474

Merged
merged 1 commit into from
Jul 31, 2024
Merged

MetadataV2.proto update #14474

merged 1 commit into from
Jul 31, 2024

Conversation

namelessssssssssss
Copy link
Contributor

What is the purpose of the change

Enhance readability and compatibility for MetadataServiceV2.proto

  • Rename Revision to MetadataRequest
  • Add param ;triple_api to go_package

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
11 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
14.4% Duplication on New Code

See analysis details on SonarCloud

@namelessssssssssss
Copy link
Contributor Author

@chickenlj PTAL

chickenlj
chickenlj approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj chickenlj merged commit 98e96d9 into apache:3.3 Jul 31, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chickenlj chickenlj chickenlj approved these changes

@AlbumenJ AlbumenJ AlbumenJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@namelessssssssssss @AlbumenJ @chickenlj