Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for configuring Tomcat HTTP2 max stream size in Spring boot #14702

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

oxsean
Copy link
Collaborator

@oxsean oxsean commented Sep 20, 2024

…Boot

What is the purpose of the change?

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@oxsean oxsean force-pushed the servlet-h2-stream-size branch 2 times, most recently from ad4f0e1 to ba8b290 Compare September 27, 2024 14:52
for (UpgradeProtocol upgradeProtocol : handler.findUpgradeProtocols()) {
if (upgradeProtocol instanceof Http2Protocol) {
Http2Protocol protocol = (Http2Protocol) upgradeProtocol;
int value = maxConcurrentStreams < 0 ? Integer.MAX_VALUE : maxConcurrentStreams;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
int value = maxConcurrentStreams < 0 ? Integer.MAX_VALUE : maxConcurrentStreams;
int value = maxConcurrentStreams <= 0 ? Integer.MAX_VALUE : maxConcurrentStreams;

@oxsean oxsean force-pushed the servlet-h2-stream-size branch from ba8b290 to 3110c80 Compare September 29, 2024 03:00
@oxsean oxsean force-pushed the servlet-h2-stream-size branch from 3110c80 to 8344001 Compare September 29, 2024 03:05
@oxsean oxsean requested a review from AlbumenJ September 29, 2024 03:06
@AlbumenJ AlbumenJ merged commit b2eba82 into apache:3.3 Sep 30, 2024
18 checks passed
@oxsean oxsean deleted the servlet-h2-stream-size branch October 23, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants