Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring6 compatibility #14866

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Conversation

oxsean
Copy link
Collaborator

@oxsean oxsean commented Nov 6, 2024

What is the purpose of the change?

Fix #14865

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@@ -982,5 +984,202 @@
<module>dubbo-demo</module>
</modules>
</profile>
<profile>
<id>spring-6</id>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make testing spring6 easier

@oxsean oxsean force-pushed the 1105-spring6-compatibility branch from d8513bb to b4ca9ba Compare November 7, 2024 13:41
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 2.19%. Comparing base (ef6e8bd) to head (b4ca9ba).
Report is 55 commits behind head on 3.3.

Additional details and impacted files
@@              Coverage Diff              @@
##              3.3    #14866        +/-   ##
=============================================
- Coverage   37.53%     2.19%    -35.34%     
=============================================
  Files        1813     26083     +24270     
  Lines       80737   1389713   +1308976     
  Branches    12005    220216    +208211     
=============================================
+ Hits        30304     30553       +249     
- Misses      46042   1354724   +1308682     
- Partials     4391      4436        +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlbumenJ AlbumenJ merged commit 8bfbb58 into apache:3.3 Nov 13, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants