Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove datasource status checker #15046

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Remove datasource status checker #15046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
104 changes: 0 additions & 104 deletions ...g-spring/src/main/java/org/apache/dubbo/config/spring/status/DataSourceStatusChecker.java
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion ...g/src/main/resources/META-INF/dubbo/internal/org.apache.dubbo.common.status.StatusChecker
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
spring=org.apache.dubbo.config.spring.status.SpringStatusChecker
datasource=org.apache.dubbo.config.spring.status.DataSourceStatusChecker
112 changes: 0 additions & 112 deletions ...ring/src/test/java/org/apache/dubbo/config/spring/status/DataSourceStatusCheckerTest.java
View file
Open in desktop

This file was deleted.

37 changes: 18 additions & 19 deletions dubbo-spring-boot-project/dubbo-spring-boot-actuator/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ If your project failed to resolve the dependency, try to add the following repos



Suppose a Spring Boot Web application did not specify `management.server.port`, you can access http://localhost:8080/actuator/health via Web Client and will get a response with JSON format is like below :
Suppose a Spring Boot Web application did not specify `management.server.port`, you can access http://localhost:8080/actuator/health via Web Client and will get a response with JSON format is like below :

```json
{
Expand Down Expand Up @@ -100,10 +100,10 @@ Suppose a Spring Boot Web application did not specify `management.server.port`,
```


`memory`, `load`, `threadpool` and `server` are Dubbo's build-in `StatusChecker`s in above example.
Dubbo allows the application to extend `StatusChecker`'s SPI.
`memory`, `load`, `threadpool` and `server` are Dubbo's build-in `StatusChecker`s in above example.
Dubbo allows the application to extend `StatusChecker`'s SPI.

Default , `memory` and `load` will be added into Dubbo's `HealthIndicator` , it could be overridden by
Default , `memory` and `load` will be added into Dubbo's `HealthIndicator` , it could be overridden by
externalized configuration [`StatusChecker`'s defaults](#statuschecker-defaults).


Expand All @@ -127,7 +127,6 @@ externalized configuration [`StatusChecker`'s defaults](#statuschecker-defaults)
```properties
registry=org.apache.dubbo.registry.status.RegistryStatusChecker
spring=org.apache.dubbo.config.spring.status.SpringStatusChecker
datasource=org.apache.dubbo.config.spring.status.DataSourceStatusChecker
memory=org.apache.dubbo.common.status.support.MemoryStatusChecker
load=org.apache.dubbo.common.status.support.LoadStatusChecker
server=org.apache.dubbo.rpc.protocol.dubbo.status.ServerStatusChecker
Expand All @@ -144,7 +143,7 @@ The property key that is name of `StatusChecker` can be a valid value of `manag



Actuator endpoint `dubbo` supports Actuator Endpoints :
Actuator endpoint `dubbo` supports Actuator Endpoints :

| ID | Enabled | HTTP URI | HTTP Method | Description | Content Type |
| ------------------- | ----------- | ----------------------------------- | ------------------ | ------------------ | ------------------ |
Expand Down Expand Up @@ -198,7 +197,7 @@ Actuator endpoint `dubbo` supports Actuator Endpoints :

#### `/actuator/dubbo`

`/dubbo` exposes Dubbo's meta data :
`/dubbo` exposes Dubbo's meta data :

```json
{
Expand All @@ -217,11 +216,11 @@ Actuator endpoint `dubbo` supports Actuator Endpoints :
}
```

###
###

#### `/actuator/dubbo/properties`

`/actuator/dubbo/properties` exposes all Dubbo's Properties from Spring Boot Externalized Configuration (a.k.a `PropertySources`) :
`/actuator/dubbo/properties` exposes all Dubbo's Properties from Spring Boot Externalized Configuration (a.k.a `PropertySources`) :

```json
{
Expand Down Expand Up @@ -380,16 +379,16 @@ The key is the string presentation of `@Reference` `Field` or `Method ` , `Refe
}
},
"ConsumerConfig": {

},
"MethodConfig": {

},
"ModuleConfig": {

},
"MonitorConfig": {

},
"ProtocolConfig": {
"dubbo": {
Expand Down Expand Up @@ -425,16 +424,16 @@ The key is the string presentation of `@Reference` `Field` or `Method ` , `Refe
}
},
"ProviderConfig": {

},
"ReferenceConfig": {

},
"RegistryConfig": {

},
"ServiceConfig": {

}
}
```
Expand Down Expand Up @@ -521,7 +520,7 @@ Compared with the `simple profiler` mode, the `detail profiler` collects more ti



`management.health.dubbo.status.defaults` is a property name for setting names of `StatusChecker`s , its value is allowed to multiple-values , for example :
`management.health.dubbo.status.defaults` is a property name for setting names of `StatusChecker`s , its value is allowed to multiple-values , for example :

```properties
management.health.dubbo.status.defaults = registry,memory,load
Expand All @@ -531,7 +530,7 @@ management.health.dubbo.status.defaults = registry,memory,load

#### Default Value

The default value is :
The default value is :

```properties
management.health.dubbo.status.defaults = memory,load
Expand Down
Loading