Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support char[] for generic invoke, #2003 #2138

Merged

Conversation

diecui1202
Copy link

What is the purpose of the change

support char[] for generic invoke

Brief changelog

dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/CompatibleTypeUtils.java

Verifying this change

add testcase

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

codecov-io commented Jul 26, 2018

Codecov Report

Merging #2138 into master will increase coverage by 0.02%.
The diff coverage is 57.14%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2138      +/-   ##
============================================
+ Coverage     54.14%   54.17%   +0.02%     
- Complexity     5091     5092       +1     
============================================
  Files           559      559              
  Lines         24931    24941      +10     
  Branches       4442     4444       +2     
============================================
+ Hits          13500    13511      +11     
+ Misses         9391     9388       -3     
- Partials       2040     2042       +2
Impacted Files Coverage Δ Complexity Δ
...apache/dubbo/common/utils/CompatibleTypeUtils.java 61.85% <57.14%> (+0.74%) 30 <0> (+1) ⬆️
...onfig/spring/extension/SpringExtensionFactory.java 78.57% <0%> (-7.15%) 10% <0%> (ø)
...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java 77.77% <0%> (-5.56%) 5% <0%> (-1%)
...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java 51.89% <0%> (-3.8%) 11% <0%> (-2%)
...bo/remoting/transport/netty/NettyCodecAdapter.java 53.12% <0%> (-1.57%) 3% <0%> (ø)
...he/dubbo/remoting/transport/netty/NettyClient.java 72.88% <0%> (-1.26%) 12% <0%> (ø)
...e/dubbo/remoting/transport/netty4/NettyClient.java 63.33% <0%> (-1.08%) 11% <0%> (ø)
...ache/dubbo/remoting/transport/mina/MinaClient.java 58.46% <0%> (-0.92%) 9% <0%> (ø)
.../dubbo/remoting/transport/netty4/NettyChannel.java 66.25% <0%> (+1.25%) 23% <0%> (+1%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0e628e...c74a8bd. Read the comment docs.

@diecui1202
Copy link
Author

The same to #2137

@zonghaishang zonghaishang merged commit ee7870c into apache:master Jul 26, 2018
@zonghaishang
Copy link
Member

It looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants