Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qos enhancement #2153

Merged
merged 8 commits into from
Aug 16, 2018
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Simplify code and add comments.
  • Loading branch information
ralf0131 committed Jul 30, 2018
commit 43b76dd1fd161b1ab6f66308e7e23eacd6a31977
Original file line number Diff line number Diff line change
@@ -71,10 +71,13 @@ public class ApplicationConfig extends AbstractConfig {
// directory for saving thread dump
private String dumpDirectory;

// whether to enable qos or not
private Boolean qosEnable;

// the qos port to listen
private Integer qosPort;

// should we accept foreign ip or not?
private Boolean qosAcceptForeignIp;

// customized parameters
Original file line number Diff line number Diff line change
@@ -33,6 +33,7 @@
import static org.apache.dubbo.common.Constants.QOS_ENABLE;
import static org.apache.dubbo.common.Constants.QOS_PORT;


public class QosProtocolWrapper implements Protocol {

private final Logger logger = LoggerFactory.getLogger(QosProtocolWrapper.class);
@@ -82,7 +83,7 @@ private void startQosServer(URL url) {
}

try {
boolean qosEnable = Boolean.parseBoolean(url.getParameter(QOS_ENABLE,"true"));
boolean qosEnable = url.getParameter(QOS_ENABLE,true);
if (!qosEnable) {
return;
}