[Dubbo-2177]Fix the issue: Supplementary unit test #2177 team 3 #2260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diecui1202
changed the title
beiwei30
reviewed
Aug 14, 2018
| import org.junit.Assert; | ||
| import org.junit.Before; | ||
| import org.junit.Test; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.List; | ||
| import java.util.*; |
| import org.apache.dubbo.common.utils.NetUtils; | ||
| import org.apache.dubbo.registry.NotifyListener; | ||
| import org.apache.log4j.BasicConfigurator; |
| @@ -36,6 +40,46 @@ | |||
| private AbstractRegistry abstractRegistry; | |||
| private boolean notifySuccess; | |||
|
|
|||
| private static final Map<String,String> parametersProvider=new LinkedHashMap<>(); | |||
|
|
||
| private List<URL> getList() { | ||
| List<URL> list = new ArrayList<>(); | ||
| URL url_1 = new URL("dubbo", "127.0.0.0", 1000); |
There was a problem hiding this comment.
don't use underscore _, instead, it's fine to name them as url1, url2, etc.
| @@ -52,8 +96,14 @@ public boolean isAvailable() { | |||
| listener = urls -> notifySuccess = true; | |||
| //notify flag | |||
| notifySuccess = false; | |||
|
|
|||
| LoggerFactory.setLevel(Level.INFO); | |||
There was a problem hiding this comment.
don't do this, instead, you should modify resources/log4j.xml
| * test register | ||
| */ | ||
| @Test | ||
| public void testRegister() { |
There was a problem hiding this comment.
pls. consider to enhance registerTest, unregisterTest, subscribeTest, unsubsribeTest, etc, instead of introducing new test methods. But your method naming is more recommended, pls. stick to it.
|
I will solve the conflict and merge part of your change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fix issue #2177 By BaiJi the 269th team 3
Brief changelog
The following branches have been Unit Tested:
org.apache.dubbo.registry.support.AbstractRegistry#register
org.apache.dubbo.registry.support.AbstractRegistry#unregister
org.apache.dubbo.registry.support.AbstractRegistry#subscribe
org.apache.dubbo.registry.support.AbstractRegistry#unsubscribe
org.apache.dubbo.registry.support.AbstractRegistry#recover
org.apache.dubbo.registry.support.AbstractRegistry#notify
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.