Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-2323]the AsyncRpcResult should store the copy of the context #2323 #2325

Merged
merged 1 commit into from
Sep 19, 2018

Conversation

bneliao
Copy link
Contributor

@bneliao bneliao commented Aug 20, 2018

What is the purpose of the change

fix #2323

Brief changelog

the AsyncRpcResult should store the copy of the context

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@kimmking
Copy link
Member

@chickenlj

@chickenlj chickenlj self-assigned this Sep 5, 2018
@chickenlj chickenlj added the type/need-triage Need maintainers to triage label Sep 5, 2018
@chickenlj
Copy link
Contributor

I will take a look at it now.

@chickenlj
Copy link
Contributor

Hi @bneliao , I think a copy of RpcContext would be a good solution, I wil merge it to master now.

Please see the comment I made on #2323.

@chickenlj chickenlj merged commit 7ad0b84 into apache:master Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/need-triage Need maintainers to triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]新版异步调用 Context 传递未必正确
3 participants