-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for caching null values #2480
Conversation
|
||
static class ValueWrapper { | ||
|
||
private final Object value; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
format your code, pls
dubbo-filter/dubbo-filter-cache/src/main/java/org/apache/dubbo/cache/filter/CacheFilter.java
Outdated
Show resolved
Hide resolved
Pls check and fix ci problem. |
The unit tests failed.
Pls. take a look. |
Support for caching null values
Codecov Report
@@ Coverage Diff @@
## master #2480 +/- ##
============================================
- Coverage 55.09% 54.97% -0.12%
- Complexity 5270 5279 +9
============================================
Files 573 573
Lines 25446 25508 +62
Branches 4518 4527 +9
============================================
+ Hits 14019 14023 +4
- Misses 9335 9389 +54
- Partials 2092 2096 +4
Continue to review full report at Codecov.
|
优化缓存括展,支持缓存null值
当前CacheFilter存在无法缓存null值问题
但是某些rpc接口被设计成可能返回空值(比如跟据用户名查询用户信息接口,如果查询不到,返回null)
增加一个内部类包装待缓存的数据
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.