Fix FailbackClusterInvoker one risk of memory leak #2425 #2822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2822 +/- ##
==========================================
- Coverage 64.38% 64.35% -0.03%
==========================================
Files 584 584
Lines 26084 26111 +27
Branches 4559 4564 +5
==========================================
+ Hits 16795 16805 +10
- Misses 7111 7122 +11
- Partials 2178 2184 +6
Continue to review full report at Codecov.
|
carryxyh
requested changes
Nov 23, 2018
dubbo-config/dubbo-config-spring/src/main/resources/META-INF/dubbo.xsd
Outdated
Show resolved
Hide resolved
| @@ -139,6 +139,10 @@ | |||
|
|
|||
| public static final int DEFAULT_RETRIES = 2; | |||
|
|
|||
| public static final int DEFAULT_FAIL_CAPACITY_SIZE = 1000; | |||
There was a problem hiding this comment.
- DEFAULT_FAIL_CAPACITY_SIZE maybe changed to DEFAULT_FAILBACK_TASKS
2.1000 is to large to us. maybe 100 is enough.
:)
There was a problem hiding this comment.
Good idea. I've changed it.
dubbo-common/src/main/java/org/apache/dubbo/common/Constants.java
Outdated
Show resolved
Hide resolved
|
|
||
| private final ConcurrentMap<Invocation, AbstractClusterInvoker<?>> failed = new ConcurrentHashMap<>(); | ||
| private volatile ScheduledFuture<?> retryFuture; | ||
| private final int failCapacitySize; |
There was a problem hiding this comment.
Good idea. I've changed it.
dubbo-common/src/main/java/org/apache/dubbo/common/Constants.java
Outdated
Show resolved
Hide resolved
carryxyh
approved these changes
Nov 26, 2018
|
@beiwei30 @chickenlj |
wangweiufofly
force-pushed
the
issues-2425
branch
from
fef8612 to
5feea92
Compare
|
Hi, @wangweiufofly |
test case completed |
wangweiufofly
force-pushed
the
issues-2425
branch
from
232a4f8 to
ad6114e
Compare
carryxyh
reviewed
Dec 24, 2018
| invoker.retryFailed();// when retry the invoker which get from failed map already is not the mocked invoker,so | ||
| // invoker.retryFailed();// when retry the invoker which get from failed map already is not the mocked invoker,so | ||
| //Ensure that the main thread is online | ||
| CountDownLatch countDown = new CountDownLatch(1); |
There was a problem hiding this comment.
I think u should assert that the logger contains the specific msg.
added 19 commits
December 24, 2018 20:26
…pacity 2.retry period,default is 100.can config by key retries. 3.shutdown the timer when destroyed
…pacity 2.retry period,default is 100.can config by key retries. 3.shutdown the timer when destroyed
2.add test case.
…pacity 2.retry period,default is 100.can config by key retries. 3.shutdown the timer when destroyed
…pacity 2.retry period,default is 100.can config by key retries. 3.shutdown the timer when destroyed
wangweiufofly
force-pushed
the
issues-2425
branch
from
ad6114e to
c132209
Compare
carryxyh
reviewed
Dec 25, 2018
| invoker.invoke(invocation); | ||
| assertEquals(1, LogUtil.findMessage("Failback to invoke")); | ||
| LogUtil.stop(); | ||
| } | ||
|
|
||
| @Test() | ||
| public void testRetryFailed() { | ||
| public void testARetryFailed() throws Exception { |
There was a problem hiding this comment.
Could u pls tell us why u rename the method and why u add the FixMethodOrder annotation?
:)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.limit the size of the map,default is 1000. can config by key failcapacity
2.retry period,default is 100.can config by key retries.
3.shutdown the timer when destroyed
The issues:
#2425