Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'continue' statement is unnecessary as the last statement in a loop #3046

Merged
merged 1 commit into from
Dec 24, 2018

Conversation

sergioescala
Copy link
Contributor

@sergioescala sergioescala commented Dec 21, 2018

What is the purpose of the change

'continue' statement is unnecessary as the last statement in a loop

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • [] Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #3046 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3046      +/-   ##
==========================================
- Coverage   64.37%   64.34%   -0.04%     
==========================================
  Files         584      584              
  Lines       26085    26084       -1     
  Branches     4559     4559              
==========================================
- Hits        16793    16783      -10     
- Misses       7115     7123       +8     
- Partials     2177     2178       +1
Impacted Files Coverage Δ
...src/main/java/org/apache/dubbo/common/Version.java 50% <ø> (+0.58%) ⬆️
...ache/dubbo/remoting/transport/AbstractChannel.java 75% <0%> (-12.5%) ⬇️
...che/dubbo/remoting/transport/mina/MinaChannel.java 43.42% <0%> (-10.53%) ⬇️
...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java 77.2% <0%> (-2.21%) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 80.07% <0%> (-1.88%) ⬇️
...he/dubbo/registry/multicast/MulticastRegistry.java 63.79% <0%> (-1.73%) ⬇️
...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java 65.83% <0%> (-0.84%) ⬇️
...dubbo/remoting/exchange/support/DefaultFuture.java 67.78% <0%> (-0.68%) ⬇️
.../java/org/apache/dubbo/config/ReferenceConfig.java 56.01% <0%> (-0.38%) ⬇️
...e/dubbo/remoting/transport/netty/NettyChannel.java 57.64% <0%> (+3.52%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 678cdb4...72ceecd. Read the comment docs.

@carryxyh carryxyh merged commit a35f942 into apache:master Dec 24, 2018
@carryxyh
Copy link
Member

Thx for your contribution. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants