[Dubbo-2999] Fixes #2999

[kezhenxu94]

What is the purpose of the change

fixes #2999

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

• Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
• Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
• Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
• If this contribution is large, please follow the Software Donation Guide.

[kezhenxu94]

Reviewers please pay special attention to the method org.apache.dubbo.registry.redis.RedisRegistry.Notifier#notifyListenersOnJedisInstance, which is extracted from the original run method,

                if (first) {
                    first = false;
                    Set<String> keys = jedis.keys(service);
                    if (keys != null && !keys.isEmpty()) {
                        for (String s : keys) {
                            doNotify(jedis, s);
                        }
                    }
                    resetSkip();
                }

the first variable is never changed before this patch, if I missed anything, please let me know.

[codecov-io]

Codecov Report

Merging #3180 into master will increase coverage by <.01%.
The diff coverage is 28.45%.

@@             Coverage Diff              @@
##             master    #3180      +/-   ##
============================================
+ Coverage     63.63%   63.63%   +<.01%     
  Complexity       75       75              
============================================
  Files           652      653       +1     
  Lines         28200    28191       -9     
  Branches       4781     4784       +3     
============================================
- Hits          17944    17939       -5     
+ Misses         8005     7979      -26     
- Partials       2251     2273      +22

Impacted Files	Coverage Δ	Complexity Δ
...c/main/java/org/apache/dubbo/common/Constants.java	92.85% <ø> (ø)	0 <0> (ø)	⬇️
...he/dubbo/registry/redis/URLJedisConfigAdapter.java	23.8% <23.8%> (ø)	0 <0> (?)
...org/apache/dubbo/registry/redis/RedisRegistry.java	40.74% <29.41%> (+7.97%)	0 <0> (ø)	⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java	58.69% <0%> (-8.7%)	0% <0%> (ø)
...in/java/org/apache/dubbo/common/utils/JVMUtil.java	73.58% <0%> (-7.55%)	0% <0%> (ø)
...ng/transport/dispatcher/all/AllChannelHandler.java	51.42% <0%> (-5.72%)	0% <0%> (ø)
.../org/apache/dubbo/remoting/ExecutionException.java	15.78% <0%> (-5.27%)	0% <0%> (ø)
.../dubbo/remoting/transport/netty4/NettyChannel.java	61.17% <0%> (-4.71%)	0% <0%> (ø)
...e/dubbo/remoting/transport/netty/NettyChannel.java	57.64% <0%> (-4.71%)	0% <0%> (ø)
...c/main/java/org/apache/dubbo/rpc/RpcException.java	82.75% <0%> (-3.45%)	0% <0%> (ø)
... and 10 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 460c3a1...df96a60. Read the comment docs.

[CrazyHZM]

Please look at this issue.#1917
Your approach is as wrong as the idea at the beginning. Let me discuss this issue first and look at my thoughts. If my idea is correct, I will reopen my pr.

[carryxyh]

@CrazyHZM
Please use UT to test the correctness of your pr.

@kezhenxu94
Hi, nice work, thx for your pr.
I glanced and found that there were several places where the changes and my other pr had duplicates. I think we can keep this pr open first, and when one of the prs is processed, we can handle the other one.

[kezhenxu94]

Thanks @carryxyh and @lixiaojiee for reviewing, I've added more comments in the updated commits.

[dubbo-bot]

Ping @kezhenxu94 . Conflict happens after merging a previous commit. Please rebase the branch against master and push it back again. Thanks a lot.

[dubbo-bot]

Ping @kezhenxu94 . Conflict happens after merging a previous commit. Please rebase the branch against master and push it back again. Thanks a lot.