Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ScriptRouter中的CompiledScript应该缓存 #390 #3524

Merged
merged 2 commits into from
Feb 21, 2019
Merged

fix ScriptRouter中的CompiledScript应该缓存 #390 #3524

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfb0d2c
fix ScriptRouter中的CompiledScript应该缓存？ #390
CrazyHZM Feb 21, 2019
0f58b7f
Empty
CrazyHZM Feb 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/router/script/ScriptRouter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,23 @@ public class ScriptRouter extends AbstractRouter {

private final String rule;

private CompiledScript function;

public ScriptRouter(URL url) {
this.url = url;
this.priority = url.getParameter(Constants.PRIORITY_KEY, 0);

engine = getEngine(url);
rule = getRule(url);
try {
Compilable compilable = (Compilable) engine;
function = compilable.compile(rule);
} catch (ScriptException e) {
logger.error("route error, rule has been ignored. rule: " + rule +
", url: " + RpcContext.getContext().getUrl(), e);
}


}

/**
Expand All @@ -72,13 +83,13 @@ private String getRule(URL url) {
}
return vRule;
}

/**
* create ScriptEngine instance by type from url parameters, then cache it
*/
private ScriptEngine getEngine(URL url) {
String type = url.getParameter(Constants.TYPE_KEY, Constants.DEFAULT_SCRIPT_TYPE_KEY);

return engines.computeIfAbsent(type, t -> {
ScriptEngine scriptEngine = new ScriptEngineManager().getEngineByName(type);
if (scriptEngine == null) {
Expand All @@ -92,8 +103,9 @@ private ScriptEngine getEngine(URL url) {
public <T> List<Invoker<T>> route(List<Invoker<T>> invokers, URL url, Invocation invocation) throws RpcException {
try {
Bindings bindings = createBindings(invokers, invocation);
Compilable compilable = (Compilable) engine;
CompiledScript function = compilable.compile(rule);
if (function == null) {
return invokers;
}
return getRoutedInvokers(function.eval(bindings));
} catch (ScriptException e) {
logger.error("route error, rule has been ignored. rule: " + rule + ", method:" +
Expand Down