-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
etcd3 integration test api #3887
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3887 +/- ##
===========================================
- Coverage 63.77% 63.67% -0.1%
Complexity 71 71
===========================================
Files 712 713 +1
Lines 31450 31455 +5
Branches 5073 5070 -3
===========================================
- Hits 20057 20029 -28
- Misses 9103 9131 +28
- Partials 2290 2295 +5
Continue to review full report at Codecov.
|
@zonghaishang hi, could pls help check this, many thanks :) |
...d/src/test/java/org/apache/dubbo/configcenter/support/etcd/EtcdDynamicConfigurationTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the pull request.
You can further improve to the org.apache.dubbo.remoting.etcd.jetcd.JEtcdClientTest
and org.apache.dubbo.remoting.etcd.jetcd.JEtcdClientWrapperTest
, which are both disabled!
I will merge this pull request. You can create a new pr to fix it.
Sure, thank you for your help. |
* etcd config center integrate test * clean code
What is the purpose of the change
fix #3631
Brief changelog
XXXXX
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.