Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcd3 integration test api #3887

Merged
merged 3 commits into from
Apr 26, 2019

Conversation

Moriadry-zz
Copy link

What is the purpose of the change

fix #3631

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

codecov-io commented Apr 18, 2019

Codecov Report

Merging #3887 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #3887     +/-   ##
===========================================
- Coverage     63.77%   63.67%   -0.1%     
  Complexity       71       71             
===========================================
  Files           712      713      +1     
  Lines         31450    31455      +5     
  Branches       5073     5070      -3     
===========================================
- Hits          20057    20029     -28     
- Misses         9103     9131     +28     
- Partials       2290     2295      +5
Impacted Files Coverage Δ Complexity Δ
.../apache/dubbo/qos/protocol/QosProtocolWrapper.java 69.23% <0%> (-12.83%) 0% <0%> (ø)
...ache/dubbo/remoting/p2p/support/AbstractGroup.java 45.45% <0%> (-11.37%) 0% <0%> (ø)
...apache/dubbo/common/config/ConfigurationUtils.java 64% <0%> (-8%) 0% <0%> (ø)
...ava/org/apache/dubbo/config/DubboShutdownHook.java 75% <0%> (-6.25%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0%> (-4.35%) 0% <0%> (ø)
...e/dubbo/remoting/transport/netty4/NettyClient.java 70.58% <0%> (-4.02%) 0% <0%> (ø)
...pache/dubbo/registry/support/AbstractRegistry.java 78.92% <0%> (-3.07%) 0% <0%> (ø)
...dubbo/remoting/exchange/support/DefaultFuture.java 73.46% <0%> (-2.73%) 0% <0%> (ø)
.../exchange/support/header/HeaderExchangeServer.java 66.98% <0%> (-1.89%) 0% <0%> (ø)
.../java/org/apache/dubbo/config/ReferenceConfig.java 60.14% <0%> (-1.09%) 0% <0%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a5f905...9c4701a. Read the comment docs.

@Moriadry-zz
Copy link
Author

@zonghaishang hi, could pls help check this, many thanks :)

Copy link
Contributor

@ralf0131 ralf0131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the pull request.

You can further improve to the org.apache.dubbo.remoting.etcd.jetcd.JEtcdClientTest and org.apache.dubbo.remoting.etcd.jetcd.JEtcdClientWrapperTest, which are both disabled!

I will merge this pull request. You can create a new pr to fix it.

@ralf0131 ralf0131 merged commit 2d0c07d into apache:master Apr 26, 2019
@Moriadry-zz
Copy link
Author

Sure, thank you for your help.

@Moriadry-zz Moriadry-zz deleted the feature/etcd-integration branch April 26, 2019 06:19
vio-lin pushed a commit to vio-lin/incubator-dubbo that referenced this pull request Apr 29, 2019
* etcd config center integrate test
* clean code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support etcd3 integration test api
4 participants