-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DUBBO-4010] TypeDefinitonBuilder support google protobuf entity build # #4011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
vio-lin
changed the title
[DUBBO-4010] [WIP] TypeDefinitonBuilder support google protobuf entity build #
[DUBBO-4010] TypeDefinitonBuilder support google protobuf entity build #
May 9, 2019
beiwei30
reviewed
May 21, 2019
...ta-definition/src/main/java/org/apache/dubbo/metadata/definition/builder/MapTypeBuilder.java
Show resolved
Hide resolved
beiwei30
reviewed
May 21, 2019
...nition/src/main/java/org/apache/dubbo/metadata/definition/builder/CollectionTypeBuilder.java
Show resolved
Hide resolved
beiwei30
reviewed
May 21, 2019
...on/src/main/java/org/apache/dubbo/common/serialize/protobuf/support/ProtobufTypeBuilder.java
Outdated
Show resolved
Hide resolved
beiwei30
reviewed
May 21, 2019
...on/src/main/java/org/apache/dubbo/common/serialize/protobuf/support/ProtobufTypeBuilder.java
Outdated
Show resolved
Hide resolved
beiwei30
reviewed
May 21, 2019
...on/src/main/java/org/apache/dubbo/common/serialize/protobuf/support/ProtobufTypeBuilder.java
Outdated
Show resolved
Hide resolved
beiwei30
reviewed
May 21, 2019
...on/src/main/java/org/apache/dubbo/common/serialize/protobuf/support/ProtobufTypeBuilder.java
Outdated
Show resolved
Hide resolved
beiwei30
reviewed
May 21, 2019
...on/src/main/java/org/apache/dubbo/common/serialize/protobuf/support/ProtobufTypeBuilder.java
Outdated
Show resolved
Hide resolved
beiwei30
reviewed
May 21, 2019
...on/src/main/java/org/apache/dubbo/common/serialize/protobuf/support/ProtobufTypeBuilder.java
Outdated
Show resolved
Hide resolved
beiwei30
reviewed
May 21, 2019
...on/src/main/java/org/apache/dubbo/common/serialize/protobuf/support/ProtobufTypeBuilder.java
Outdated
Show resolved
Hide resolved
beiwei30
reviewed
May 21, 2019
...on/src/main/java/org/apache/dubbo/common/serialize/protobuf/support/ProtobufTypeBuilder.java
Outdated
Show resolved
Hide resolved
add test case to test NestPbType
vio-lin
force-pushed
the
add-googlePbTypeBuilder
branch
from
May 22, 2019 05:05
7829bce
to
b72a095
Compare
Codecov Report
@@ Coverage Diff @@
## master #4011 +/- ##
===========================================
+ Coverage 62.63% 62.74% +0.1%
+ Complexity 543 473 -70
===========================================
Files 762 763 +1
Lines 32752 32845 +93
Branches 5162 5182 +20
===========================================
+ Hits 20515 20608 +93
+ Misses 9876 9866 -10
- Partials 2361 2371 +10
Continue to review full report at Codecov.
|
beiwei30
approved these changes
May 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
TypeDefinitonBuilder support google protobuf service metadata generating
Brief changelog
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.