Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DUBBO-4010] TypeDefinitonBuilder support google protobuf entity build # #4011

Merged
merged 3 commits into from
May 22, 2019

Conversation

vio-lin
Copy link
Contributor

@vio-lin vio-lin commented May 9, 2019

What is the purpose of the change

TypeDefinitonBuilder support google protobuf service metadata generating

Brief changelog

  1. change TypeDefinitionBuilder use SPI to load custom TypeBuilder
  2. add GooglePbTypeBuilder in dubbo-serialization-protobuf-json to build Protobuf entity class

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@vio-lin vio-lin changed the title [DUBBO-4010] [WIP] TypeDefinitonBuilder support google protobuf entity build # [DUBBO-4010] TypeDefinitonBuilder support google protobuf entity build # May 9, 2019
@vio-lin vio-lin force-pushed the add-googlePbTypeBuilder branch from 7829bce to b72a095 Compare May 22, 2019 05:05
@codecov-io
Copy link

Codecov Report

Merging #4011 into master will increase coverage by 0.1%.
The diff coverage is 71.69%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #4011     +/-   ##
===========================================
+ Coverage     62.63%   62.74%   +0.1%     
+ Complexity      543      473     -70     
===========================================
  Files           762      763      +1     
  Lines         32752    32845     +93     
  Branches       5162     5182     +20     
===========================================
+ Hits          20515    20608     +93     
+ Misses         9876     9866     -10     
- Partials       2361     2371     +10
Impacted Files Coverage Δ Complexity Δ
...bbo/metadata/definition/TypeDefinitionBuilder.java 100% <100%> (ø) 0 <0> (-9) ⬇️
...bo/metadata/definition/builder/MapTypeBuilder.java 52.63% <50%> (+5.01%) 0 <0> (-5) ⬇️
...data/definition/builder/CollectionTypeBuilder.java 52.63% <50%> (+5.01%) 0 <0> (-4) ⬇️
...erialize/protobuf/support/ProtobufTypeBuilder.java 70.52% <70.52%> (ø) 0 <0> (?)
...ache/dubbo/remoting/transport/AbstractChannel.java 75% <0%> (-12.5%) 0% <0%> (ø)
...onfig/spring/extension/SpringExtensionFactory.java 80.48% <0%> (-4.88%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 58.69% <0%> (-4.35%) 0% <0%> (ø)
...he/dubbo/remoting/transport/netty/NettyServer.java 69.64% <0%> (-3.58%) 8% <0%> (-1%)
.../exchange/support/header/HeaderExchangeServer.java 67.92% <0%> (+0.94%) 0% <0%> (ø) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fc6909...b72a095. Read the comment docs.

@beiwei30 beiwei30 merged commit a7f56a3 into apache:master May 22, 2019
@vio-lin vio-lin deleted the add-googlePbTypeBuilder branch September 28, 2021 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants