Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DUBBO-3137]: step3 - start to use ClusterConstants and MonitorConstants #4045

Merged
merged 1 commit into from
May 13, 2019
Merged

[DUBBO-3137]: step3 - start to use ClusterConstants and MonitorConstants #4045

merged 1 commit into from
May 13, 2019

Conversation

beiwei30
Copy link
Member

What is the purpose of the change

issue #3137: step3 - start to use ClusterConstants and MonitorConstants

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #4045 into master will decrease coverage by 0.63%.
The diff coverage is 72.72%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4045      +/-   ##
============================================
- Coverage     63.11%   62.47%   -0.64%     
  Complexity      564      564              
============================================
  Files           753      774      +21     
  Lines         32411    34254    +1843     
  Branches       5143     5384     +241     
============================================
+ Hits          20455    21399     +944     
- Misses         9604    10393     +789     
- Partials       2352     2462     +110
Impacted Files Coverage Δ Complexity Δ
...in/java/org/apache/dubbo/config/MetricsConfig.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...c/main/java/org/apache/dubbo/common/Constants.java 75% <ø> (ø) 0 <0> (ø) ⬇️
...g/apache/dubbo/config/AbstractReferenceConfig.java 94% <ø> (ø) 0 <0> (ø) ⬇️
...e/dubbo/registry/integration/RegistryProtocol.java 82.69% <ø> (ø) 0 <0> (ø) ⬇️
.../java/org/apache/dubbo/config/ReferenceConfig.java 59.85% <0%> (ø) 0 <0> (ø) ⬇️
...g/apache/dubbo/config/AbstractInterfaceConfig.java 72% <0%> (ø) 0 <0> (ø) ⬇️
...in/java/org/apache/dubbo/config/ServiceConfig.java 58.2% <0%> (ø) 0 <0> (ø) ⬇️
...dubbo/rpc/cluster/directory/AbstractDirectory.java 96.96% <100%> (ø) 0 <0> (ø) ⬇️
...che/dubbo/registry/dubbo/DubboRegistryFactory.java 89.74% <100%> (ø) 6 <0> (ø) ⬇️
.../rpc/cluster/router/mock/MockInvokersSelector.java 94.44% <100%> (ø) 0 <0> (ø) ⬇️
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e690864...dab0bdb. Read the comment docs.

Copy link
Member

@CrazyHZM CrazyHZM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CrazyHZM CrazyHZM merged commit 175eab1 into apache:master May 13, 2019
@beiwei30 beiwei30 deleted the issue3137 branch May 14, 2019 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants