Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DUBBO-3137]: step4 - move more constants from RemotingConstants into dubbo-remoting-api #4077

Merged
merged 2 commits into from
May 16, 2019
Merged

Conversation

beiwei30
Copy link
Member

@beiwei30 beiwei30 commented May 16, 2019

What is the purpose of the change

issue #3137: step4 - move more constants from RemotingConstants into dubbo-remoting-api

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@beiwei30 beiwei30 requested a review from CrazyHZM May 16, 2019 08:10
@codecov-io
Copy link

Codecov Report

Merging #4077 into master will increase coverage by <.01%.
The diff coverage is 75.89%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #4077      +/-   ##
===========================================
+ Coverage     62.99%     63%   +<.01%     
  Complexity      544     544              
===========================================
  Files           756     756              
  Lines         32578   32578              
  Branches       5163    5163              
===========================================
+ Hits          20523   20525       +2     
+ Misses         9694    9693       -1     
+ Partials       2361    2360       -1
Impacted Files Coverage Δ Complexity Δ
...che/dubbo/registry/dubbo/DubboRegistryFactory.java 89.74% <ø> (ø) 6 <0> (ø) ⬇️
...src/main/java/org/apache/dubbo/remoting/Codec.java 100% <ø> (ø) 0 <0> (ø) ⬇️
...pache/dubbo/monitor/dubbo/DubboMonitorFactory.java 100% <ø> (ø) 6 <0> (ø) ⬇️
...rc/main/java/org/apache/dubbo/remoting/Codec2.java 100% <ø> (ø) 0 <0> (ø) ⬇️
...he/dubbo/remoting/transport/netty/NettyClient.java 66.1% <ø> (ø) 11 <0> (ø) ⬇️
...java/org/apache/dubbo/remoting/etcd/Constants.java 100% <ø> (ø) 0 <0> (ø) ⬇️
...g/apache/dubbo/config/AbstractReferenceConfig.java 94% <ø> (ø) 0 <0> (ø) ⬇️
...e/dubbo/registry/integration/RegistryProtocol.java 82.69% <ø> (ø) 0 <0> (ø) ⬇️
...ache/dubbo/remoting/transport/mina/MinaServer.java 63.33% <ø> (ø) 6 <0> (ø) ⬇️
.../apache/dubbo/remoting/p2p/support/ServerPeer.java 21.27% <0%> (ø) 0 <0> (ø) ⬇️
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1798fed...5d90ace. Read the comment docs.

Copy link
Member

@CrazyHZM CrazyHZM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CrazyHZM CrazyHZM merged commit 228cad5 into apache:master May 16, 2019
@beiwei30 beiwei30 deleted the issue3137 branch May 16, 2019 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants