-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow @Service and @Reference to merge attributes form annotations in lower levels of the annotation hierachy. #4078
Conversation
… lower levels of the annotation hierachy.
sync apache version
merge apache to dhchao11
[DUBBO-4010] TypeDefinitonBuilder support google protobuf entity buil…
Codecov Report
@@ Coverage Diff @@
## master #4078 +/- ##
============================================
- Coverage 62.66% 62.11% -0.56%
- Complexity 473 474 +1
============================================
Files 763 784 +21
Lines 32845 34688 +1843
Branches 5182 5423 +241
============================================
+ Hits 20582 21545 +963
- Misses 9894 10668 +774
- Partials 2369 2475 +106
Continue to review full report at Codecov.
|
please review, tks |
merge from apache dubbo
merge incubator-dubbo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at my comment.
...g-spring/src/test/java/org/apache/dubbo/config/spring/annotation/merged/MergedReference.java
Outdated
Show resolved
Hide resolved
...g-spring/src/test/java/org/apache/dubbo/config/spring/annotation/merged/MergedReference.java
Outdated
Show resolved
Hide resolved
...fig-spring/src/test/java/org/apache/dubbo/config/spring/annotation/merged/MergedService.java
Outdated
Show resolved
Hide resolved
...fig-spring/src/test/java/org/apache/dubbo/config/spring/annotation/merged/MergedService.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for your PR, approved and merged |
my pleasure, thank you all |
… lower levels of the annotation hierachy. (apache#4078) * allow @service and @reference to merge attributes form annotations in lower levels of the annotation hierachy. * remove author information & not introduce all dependencies for test
… lower levels of the annotation hierachy. (apache#4078) * allow @service and @reference to merge attributes form annotations in lower levels of the annotation hierachy. * remove author information & not introduce all dependencies for test
What is the purpose of the change
the related issue is :
#4075
Brief changelog
allow @service and @reference to merge attributes form annotations in lower levels of the annotation hierachy.
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.