Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow @Service and @Reference to merge attributes form annotations in lower levels of the annotation hierachy. #4078

Merged
merged 7 commits into from
Jun 27, 2019

Conversation

dhchao11
Copy link
Contributor

What is the purpose of the change

the related issue is :
#4075

Brief changelog

allow @service and @reference to merge attributes form annotations in lower levels of the annotation hierachy.

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

… lower levels of the annotation hierachy.
dhchao11 added 3 commits May 17, 2019 11:25
merge apache to dhchao11
[DUBBO-4010] TypeDefinitonBuilder support google protobuf entity buil…
@codecov-io
Copy link

Codecov Report

Merging #4078 into master will decrease coverage by 0.55%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4078      +/-   ##
============================================
- Coverage     62.66%   62.11%   -0.56%     
- Complexity      473      474       +1     
============================================
  Files           763      784      +21     
  Lines         32845    34688    +1843     
  Branches       5182     5423     +241     
============================================
+ Hits          20582    21545     +963     
- Misses         9894    10668     +774     
- Partials       2369     2475     +106
Impacted Files Coverage Δ Complexity Δ
...ompatibleReferenceAnnotationBeanPostProcessor.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../CompatibleServiceAnnotationBeanPostProcessor.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...annotation/ServiceAnnotationBeanPostProcessor.java 78.76% <100%> (ø) 0 <0> (ø) ⬇️
...nnotation/AnnotationInjectedBeanPostProcessor.java 65.75% <100%> (ø) 0 <0> (ø) ⬇️
...onfig/spring/extension/SpringExtensionFactory.java 80.48% <0%> (-4.88%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0%> (-2.18%) 0% <0%> (ø)
...pache/dubbo/registry/support/AbstractRegistry.java 78.54% <0%> (-1.54%) 0% <0%> (ø)
.../dubbo/remoting/transport/netty4/NettyChannel.java 64.7% <0%> (-1.18%) 0% <0%> (ø)
...pache/dubbo/remoting/transport/AbstractServer.java 47.91% <0%> (-1.05%) 0% <0%> (ø)
...a/org/apache/dubbo/common/json/ParseException.java 0% <0%> (ø) 0% <0%> (?)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7f56a3...7424c4f. Read the comment docs.

@dhchao11
Copy link
Contributor Author

please review, tks

dhchao11 added 2 commits June 4, 2019 15:00
Copy link
Member

@CrazyHZM CrazyHZM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at my comment.

@chickenlj chickenlj added this to the 2.7.3 milestone Jun 27, 2019
Copy link
Contributor

@mercyblitz mercyblitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mercyblitz mercyblitz merged commit 1a9ddd8 into apache:master Jun 27, 2019
@mercyblitz
Copy link
Contributor

Thanks for your PR, approved and merged

@dhchao11
Copy link
Contributor Author

my pleasure, thank you all

rolandhe pushed a commit to rolandhe/dubbo that referenced this pull request Sep 9, 2019
… lower levels of the annotation hierachy. (apache#4078)

* allow @service and @reference to merge attributes form annotations in lower levels of the annotation hierachy.

* remove author information & not introduce all dependencies for test
rolandhe pushed a commit to rolandhe/dubbo that referenced this pull request Sep 9, 2019
… lower levels of the annotation hierachy. (apache#4078)

* allow @service and @reference to merge attributes form annotations in lower levels of the annotation hierachy.

* remove author information & not introduce all dependencies for test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants