Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

performance improve for DefaultFuture and AsyncToSyncInvoker #4085

Merged
merged 2 commits into from
May 21, 2019

Conversation

Jeff-Lv
Copy link
Contributor

@Jeff-Lv Jeff-Lv commented May 17, 2019

What is the purpose of the change

when I do stress testing, I found that the latest of version 3.0-dev with low performance for qps and rt, actually very impressive low compare to 2.7.1.

Brief changelog

the main problem is about those two classes.

Copy link
Member

@carryxyh carryxyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这样好像是不太够的。
task如果不被cancel,就一定会被放到HashedWheelTimer的bucket里,这样会延长task的生命周期,导致YGC的时候task在堆里被copy来copy去。

从云音乐的rpc压测结果来看,cancel掉对应的task可以让GC的效果更好一些。

@carryxyh carryxyh mentioned this pull request May 17, 2019
@carryxyh
Copy link
Member

个人感觉,这两个pr合并在一起效果是最好的:
#4087

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chickenlj
Copy link
Contributor

个人感觉,这两个pr合并在一起效果是最好的:
#4087

Agree with you. I will merge your patch manually later.

@chickenlj chickenlj merged commit 0d0ad0a into apache:3.x-dev May 21, 2019
chickenlj added a commit to chickenlj/incubator-dubbo that referenced this pull request May 23, 2019
carryxyh pushed a commit that referenced this pull request May 23, 2019
Performance tuning for TimeoutTask in DefaultFuture, manually merge #4085 and #4087
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants