Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incubator #4161

Merged
merged 53 commits into from
May 24, 2019
Merged

Remove incubator #4161

merged 53 commits into from
May 24, 2019

Conversation

lovepoem
Copy link
Member

What is the purpose of the change

remove incubator

Brief changelog

some config files

Verifying this change

ci pass

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

lovepoem and others added 30 commits January 22, 2019 19:47
@lovepoem lovepoem closed this May 24, 2019
@lovepoem lovepoem deleted the remove_incubator branch May 24, 2019 15:46
@lovepoem lovepoem restored the remove_incubator branch May 24, 2019 15:46
@lovepoem lovepoem deleted the remove_incubator branch May 24, 2019 15:46
@lovepoem lovepoem restored the remove_incubator branch May 24, 2019 15:47
@lovepoem lovepoem reopened this May 24, 2019
Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think maybe there are also "incubating" that should be removed :)

@lovepoem
Copy link
Member Author

I think maybe there are also "incubating" that should be removed :)

done by 5365219

@lovepoem
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants