Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize some code styles #4260

Merged
merged 2 commits into from
Jul 22, 2019
Merged

optimize some code styles #4260

merged 2 commits into from
Jul 22, 2019

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Jun 6, 2019

Signed-off-by: jimin.jm slievrly@163.com

What is the purpose of the change

optimize some code styles

Brief changelog

optimize some code styles

Verifying this change

ci

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

slievrly added 2 commits June 6, 2019 12:53
Signed-off-by: jimin.jm <slievrly@163.com>
Signed-off-by: jimin.jm <slievrly@163.com>
Copy link

@Moriadry-zz Moriadry-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either L or l can be used, both indicate a long primitive, so what's the purpose of changing it?

@lixiaojiee
Copy link
Contributor

You submit too many changes, I suggest submitting by module.

@slievrly
Copy link
Member Author

You submit too many changes, I suggest submitting by module.

submitted pr is a non-functional change, code-standard cleanup

Copy link
Member

@beiwei30 beiwei30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants