Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-4340]Throws exception whenever SPI extensions are in abnormal status during loading. #5072

Merged
merged 1 commit into from
Sep 17, 2019

Conversation

chickenlj
Copy link
Contributor

What is the purpose of the change

Fixes #4340

Brief changelog

Split findException into two sperate functions, with one called before loading and another called after loading.

@cvictory cvictory added this to the 2.7.4 milestone Sep 17, 2019
Copy link
Contributor

@cvictory cvictory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cvictory cvictory merged commit 3844ac7 into apache:master Sep 17, 2019
@cvictory
Copy link
Contributor

包下载有点问题。

chickenlj added a commit to chickenlj/incubator-dubbo that referenced this pull request Sep 19, 2019
cvictory pushed a commit that referenced this pull request Sep 19, 2019
chickenlj added a commit that referenced this pull request Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ExtensionLoader 加载重复 filter,出现 Duplicate extension 被 exceptions 获取后却不抛出来
2 participants