Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apollo config center optimization, use 'dubbo.properties' as default namespace for properties. #5105

Merged
merged 5 commits into from
Sep 24, 2019

Conversation

chickenlj
Copy link
Contributor

No description provided.

@CodingSinger
Copy link
Member

这样改有点问题,org.apache.dubbo.config.AbstractInterfaceConfig#prepareEnvironment这个方法中的对appConfigFile的获取就会失去原来的语义了,不再从名为application name这个namespace中获取。

@CodingSinger
Copy link
Member

看了一下,getProperties方法大概只被启动初始化的org.apache.dubbo.config.AbstractInterfaceConfig#prepareEnvironment用到,我建议是否可以考虑修改该方法,保留原来的语义,即将group作为apollo namespace,并且application name作为app cloud config?

@codecov-io
Copy link

codecov-io commented Sep 24, 2019

Codecov Report

Merging #5105 into 2.7.4-release will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             2.7.4-release    #5105      +/-   ##
===================================================
- Coverage               64%   63.98%   -0.02%     
- Complexity             451      452       +1     
===================================================
  Files                  770      770              
  Lines                33235    33268      +33     
  Branches              5224     5250      +26     
===================================================
+ Hits                 21271    21288      +17     
- Misses                9533     9549      +16     
  Partials              2431     2431
Impacted Files Coverage Δ Complexity Δ
...ter/support/apollo/ApolloDynamicConfiguration.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../apache/dubbo/qos/protocol/QosProtocolWrapper.java 65.85% <0%> (-17.08%) 0% <0%> (ø)
.../remoting/transport/netty4/NettyServerHandler.java 61.9% <0%> (-9.53%) 0% <0%> (ø)
...ng/transport/dispatcher/all/AllChannelHandler.java 51.42% <0%> (-5.72%) 0% <0%> (ø)
.../org/apache/dubbo/remoting/ExecutionException.java 15.78% <0%> (-5.27%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 58.69% <0%> (-4.35%) 0% <0%> (ø)
...dubbo/common/status/support/LoadStatusChecker.java 46.15% <0%> (-3.85%) 0% <0%> (ø)
...exchange/support/header/HeaderExchangeHandler.java 64.75% <0%> (-2.46%) 0% <0%> (ø)
.../rpc/protocol/dubbo/LazyConnectExchangeClient.java 56.47% <0%> (-2.36%) 0% <0%> (ø)
.../dubbo/remoting/transport/netty4/NettyChannel.java 64.77% <0%> (-2.28%) 0% <0%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96e7c65...5628f8d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants