Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-Performance] Reuse Hessian2Output and Hessian2Input instance to reduce memor… #5889

Merged

Conversation

LinShunKang
Copy link
Contributor

@LinShunKang LinShunKang commented Mar 19, 2020

…y allocation.

What is the purpose of the change

Reduce memory allocation.

Brief changelog

  • Use ThreadLocal<Hessian2Input> to create new Hessian2ObjectInput instance instead of create new Hessian2Input instance.
  • Use ThreadLocal<Hessian2Output> to create new Hessian2ObjectOutput instance instead of create new Hessian2Output instance.

Verifying this change

For more information: Hessian2Optimize

Follow this checklist to help us incorporate your contribution quickly and easily:

  • [] Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@LinShunKang LinShunKang marked this pull request as ready for review March 19, 2020 15:29
@LinShunKang
Copy link
Contributor Author

@chickenlj @beiwei30 PTAL.

@beiwei30 beiwei30 self-requested a review March 20, 2020 08:08
@beiwei30 beiwei30 added this to the 2.7.7 milestone Mar 20, 2020
@beiwei30
Copy link
Member

I filed #5892 to track this task.

@chickenlj
Copy link
Contributor

Does create Hessian2Input turns out to have an obvious performance affection.

@chickenlj chickenlj merged commit 78d5277 into apache:master Apr 7, 2020
vio-lin added a commit to vio-lin/incubator-dubbo that referenced this pull request Feb 22, 2023
perf: Reuse Hessian2Output and Hessian2Input instance to reduce memory allocation. (apache#5889)  fixes apache#5892
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants