-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dubbo-fix]: polish LFUCache #5994
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5994 +/- ##
============================================
- Coverage 58.65% 58.64% -0.02%
Complexity 424 424
============================================
Files 1043 1043
Lines 42473 42472 -1
Branches 6212 6211 -1
============================================
- Hits 24912 24907 -5
- Misses 14773 14779 +6
+ Partials 2788 2786 -2 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Approved.
@chickenlj |
@tangcent hi, thanks for your contribution pls resolve confilcts with the latest master branch |
@AlbumenJ done. |
What is the purpose of the change
review #5734
Brief changelog
DEFAULT_LOAD_FACTOR -> DEFAULT_CAPACITY
DEFAULT_EVICTION_CAPACITY -> DEFAULT_EVICTION_FACTOR
org.apache.dubbo.common.utils.LRUCacheTest#testErrorConstructArguments
.Verifying this change
Run test case
org.apache.dubbo.common.utils.LRUCacheTest
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.