Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dubbo-provider.xml #6857

Merged
merged 1 commit into from
Nov 9, 2020
Merged

Update dubbo-provider.xml #6857

merged 1 commit into from
Nov 9, 2020

Conversation

baymaxxjf
Copy link

What is the purpose of the change

XXXXX

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@htynkn
Copy link
Member

htynkn commented Nov 6, 2020

could you please provide more detail for this PR?

@htynkn htynkn added the status/waiting-for-feedback Need reporters to triage label Nov 6, 2020
@baymaxxjf
Copy link
Author

could you please provide more detail for this PR?
不修改该地址zookeeper://127.0.0.1:2181?registry-type=service会报错,

@htynkn
Copy link
Member

htynkn commented Nov 9, 2020

@htynkn htynkn merged commit 4a265a5 into apache:master Nov 9, 2020
@htynkn
Copy link
Member

htynkn commented Nov 9, 2020

thanks for your contribution

@htynkn htynkn removed the status/waiting-for-feedback Need reporters to triage label Nov 9, 2020
chickenlj pushed a commit to chickenlj/incubator-dubbo that referenced this pull request Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants