Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix field name for Wrapper.java #6870

Merged
merged 2 commits into from
Nov 6, 2020
Merged

Conversation

LeeGuoPing
Copy link

What is the purpose of the change

maybe there should be overload not override

Brief changelog

change override to overload

Verifying this change

change override to overload In Wrapper class

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@htynkn htynkn added type/refactor type/need-triage Need maintainers to triage labels Nov 5, 2020
@htynkn htynkn changed the title Dubbo lgp overload fix field name for Wrapper.java Nov 6, 2020
@htynkn htynkn added status/READY-TO-MERGE and removed type/need-triage Need maintainers to triage labels Nov 6, 2020
@htynkn htynkn merged commit 4b0dc35 into apache:master Nov 6, 2020
@htynkn
Copy link
Member

htynkn commented Nov 6, 2020

thanks for your contribution

chickenlj pushed a commit to chickenlj/incubator-dubbo that referenced this pull request Nov 25, 2020
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants