Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix samples urls in README #6949

Merged
merged 1 commit into from
Dec 18, 2020
Merged

Fix samples urls in README #6949

merged 1 commit into from
Dec 18, 2020

Conversation

kacperfronc
Copy link

What is the purpose of the change

URLs in readmes pointing to samples are broken.

Brief changelog

Simple fix to 4 urls.

Verifying this change

Open old/new in browser

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

codecov-io commented Nov 27, 2020

Codecov Report

Merging #6949 (8e14f97) into master (3fc2d10) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6949      +/-   ##
============================================
- Coverage     59.44%   59.36%   -0.08%     
+ Complexity      511      508       -3     
============================================
  Files          1028     1028              
  Lines         41519    41519              
  Branches       6037     6037              
============================================
- Hits          24679    24647      -32     
- Misses        14104    14123      +19     
- Partials       2736     2749      +13     
Impacted Files Coverage Δ Complexity Δ
...ng/transport/dispatcher/all/AllChannelHandler.java 82.75% <0.00%> (-6.90%) 0.00% <0.00%> (ø%)
...e/dubbo/remoting/transport/netty/NettyChannel.java 55.68% <0.00%> (-4.55%) 20.00% <0.00%> (-1.00%)
...mmon/serialize/kryo/utils/AbstractKryoFactory.java 75.43% <0.00%> (-3.51%) 0.00% <0.00%> (ø%)
...g/apache/dubbo/rpc/protocol/rest/RestProtocol.java 68.21% <0.00%> (-3.11%) 0.00% <0.00%> (ø%)
...g/apache/dubbo/config/AbstractInterfaceConfig.java 85.18% <0.00%> (-2.47%) 0.00% <0.00%> (ø%)
...he/dubbo/rpc/protocol/hessian/HessianProtocol.java 67.46% <0.00%> (-2.41%) 9.00% <0.00%> (ø%)
...n/java/org/apache/dubbo/config/RegistryConfig.java 84.12% <0.00%> (-2.39%) 0.00% <0.00%> (ø%)
...pache/dubbo/registry/support/AbstractRegistry.java 79.25% <0.00%> (-1.86%) 0.00% <0.00%> (ø%)
...ache/dubbo/cache/support/expiring/ExpiringMap.java 40.35% <0.00%> (-1.76%) 0.00% <0.00%> (ø%)
...che/dubbo/remoting/transport/mina/MinaChannel.java 50.00% <0.00%> (-1.32%) 16.00% <0.00%> (-1.00%)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fc2d10...8e14f97. Read the comment docs.

@htynkn htynkn merged commit e84cdc2 into apache:master Dec 18, 2020
@htynkn
Copy link
Member

htynkn commented Dec 18, 2020

thanks for your contribution

@htynkn htynkn mentioned this pull request Dec 18, 2020
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants