-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dubbo-6963] fix bug: delete last config not take effect #6964
[Dubbo-6963] fix bug: delete last config not take effect #6964
Conversation
...stry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/client/RegistryProtocol.java
Outdated
Show resolved
Hide resolved
@wikiwikiwiki Hi, thanks for your contribution. Please merge the latest master branch to resolve confilcts. |
# Conflicts: # dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/integration/RegistryProtocol.java
already resolved |
Codecov Report
@@ Coverage Diff @@
## master #6964 +/- ##
============================================
- Coverage 59.17% 59.13% -0.04%
Complexity 529 529
============================================
Files 1076 1076
Lines 43451 43451
Branches 6352 6352
============================================
- Hits 25711 25696 -15
- Misses 14901 14919 +18
+ Partials 2839 2836 -3
Continue to review full report at Codecov.
|
LGTM. @wikiwikiwiki Do you have any time to add some unit test cases for this? I will merge this pr later, and we can do it in a new pull request. |
ok |
* fix bug: delete last config not take effect * merge master
fix #6963 ,修复删除最后一条动态配置不会生效的问题