Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the constant name in LFUCache #7094

Merged
merged 1 commit into from
Jan 15, 2021
Merged

Conversation

xuekg
Copy link

@xuekg xuekg commented Jan 11, 2021

What is the purpose of the change

fix the constant name in LFUCache

Brief changelog

ensure the legibility of code

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

codecov-io commented Jan 11, 2021

Codecov Report

Merging #7094 (5f6cd17) into master (f7127c7) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7094      +/-   ##
============================================
- Coverage     59.23%   59.15%   -0.08%     
+ Complexity      510      506       -4     
============================================
  Files          1028     1028              
  Lines         41525    41525              
  Branches       6038     6038              
============================================
- Hits          24597    24565      -32     
- Misses        14167    14195      +28     
- Partials       2761     2765       +4     
Impacted Files Coverage Δ Complexity Δ
...n/java/org/apache/dubbo/common/utils/LFUCache.java 79.61% <100.00%> (ø) 0.00 <0.00> (ø)
...he/dubbo/common/threadpool/ThreadlessExecutor.java 52.17% <0.00%> (-10.87%) 0.00% <0.00%> (ø%)
...che/dubbo/remoting/transport/mina/MinaChannel.java 39.47% <0.00%> (-10.53%) 15.00% <0.00%> (-1.00%)
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 62.06% <0.00%> (-10.35%) 0.00% <0.00%> (ø%)
...e/dubbo/remoting/transport/netty/NettyChannel.java 55.68% <0.00%> (-4.55%) 20.00% <0.00%> (-1.00%)
...dubbo/remoting/exchange/support/DefaultFuture.java 74.35% <0.00%> (-4.28%) 0.00% <0.00%> (ø%)
...he/dubbo/remoting/transport/netty/NettyServer.java 70.17% <0.00%> (-3.51%) 8.00% <0.00%> (-1.00%)
...pache/dubbo/registry/support/AbstractRegistry.java 77.77% <0.00%> (-3.34%) 0.00% <0.00%> (ø%)
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 86.66% <0.00%> (-2.86%) 16.00% <0.00%> (-1.00%)
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 62.88% <0.00%> (-0.69%) 0.00% <0.00%> (ø%)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7127c7...5f6cd17. Read the comment docs.

Copy link
Contributor

@ralf0131 ralf0131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ralf0131 ralf0131 merged commit 594a68f into apache:master Jan 15, 2021
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants