-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[More Optimize]Heartbeat skip serialize and deserialize #7168
[More Optimize]Heartbeat skip serialize and deserialize #7168
Conversation
…rialize_and_deserialize
LGTM |
Codecov Report
@@ Coverage Diff @@
## master #7168 +/- ##
============================================
- Coverage 60.01% 59.61% -0.40%
+ Complexity 289 287 -2
============================================
Files 1001 1001
Lines 39994 39999 +5
Branches 5941 5942 +1
============================================
- Hits 24002 23846 -156
- Misses 13290 13444 +154
- Partials 2702 2709 +7 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What is the purpose of the change
在 #7077 基础上进一步优化,使用ThreadLocal<byte[]> 降低每次读取event的payload的内存开销。
Brief changelog
增加静态成员ThreadLocal<byte[]>,当读取event的payload时,获取当前NIO线程对应的byte[],避免每次读取payload都要分配byte[]。
NIO线程有限(DUBBO默认CPU+1),ThreadLocal内byte[]有限。
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.