Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

路由优化 #749

Merged
merged 1 commit into from
Oct 23, 2017
Merged

路由优化 #749

merged 1 commit into from
Oct 23, 2017

Conversation

Just-CJ
Copy link
Contributor

@Just-CJ Just-CJ commented Oct 18, 2017

RegistryDirectory里面这段代码,完全可以先对invokers先做一遍route,因为不是所有路由策略都是方法级别的

之所以想改这个,是因为我们公司开发了一个api网关(基于dubbox的),是一个伪造的dubbo comsumer,也能用dubbo的服务发现,但是我本地类只是一个httpClient,代码上做了一些侵入性改造,执行到下面这段代码时serviceMethods这个变量是null,按照原来的逻辑只要serviceMethods为null,就不会做路由了,但是我希望至少支持service级别的路由

@CLAassistant
Copy link

CLAassistant commented Oct 18, 2017

CLA assistant check
All committers have signed the CLA.

@chickenlj chickenlj merged commit 62fae04 into apache:master Oct 23, 2017
xpylq pushed a commit to xpylq/dubbo that referenced this pull request Oct 24, 2017
* remotes/upstream/master:
  Fix all unit test case
  Merge pull request apache#107 from sonicwu:master
  Open UT on travis
  Merge pull request apache#749 from Just-CJ:master
  Fix config error of heartbeat UT in dubbo-test-examples
  Merge pull request apache#755 from Elin-Zhou:master
  Merge pull request apache#748 from mysqto:master
  Merge pull request apache#765 from hollyshi:patch-1
  Delete dubbo1 rpc protocol copatipable logic
  Create Contributing.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants