Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize putIfAbsent method to computeIfAbsent which may reduce some … #7543

Merged
merged 1 commit into from
Apr 15, 2021

Conversation

likemoongg
Copy link
Contributor

[Dubbo-7542] optimize creation of Objet

What is the purpose of the change

optimize 7542
replace putIfAbsent method with computeIfAbsent to reduce extra creation of Object.

Brief changelog

Verifying this change

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link
Member

@horizonzy horizonzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@likemoongg likemoongg closed this Apr 14, 2021
@likemoongg likemoongg reopened this Apr 14, 2021
@likemoongg
Copy link
Contributor Author

closing this pr is a misoperation of mine ,sorry...

@horizonzy
Copy link
Member

Some UT failed, check it.

Copy link
Contributor

@xiaoheng1 xiaoheng1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlbumenJ AlbumenJ merged commit a666294 into apache:master Apr 15, 2021
AlbumenJ added a commit that referenced this pull request Apr 15, 2021
…ce some creation of object. (#7543)"

This reverts commit a666294.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants