Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter Order was disrupted when user application extends the SPI of org.apache.dubbo.rpc.Filter #7778

Merged
merged 1 commit into from
May 19, 2021

Conversation

xiaoheng1
Copy link
Contributor

What is the purpose of the change

Filter Order was disrupted when user application extends the SPI of org.apache.dubbo.rpc.Filter

see more detail from #7757

Brief changelog

Verifying this change

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

…nds the SPI of org.apache.dubbo.rpc.Filter
@codecov-commenter
Copy link

codecov-commenter commented May 17, 2021

Codecov Report

Merging #7778 (9916953) into master (e845e16) will increase coverage by 0.15%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7778      +/-   ##
============================================
+ Coverage     59.28%   59.43%   +0.15%     
- Complexity      529      556      +27     
============================================
  Files          1077     1083       +6     
  Lines         43565    43753     +188     
  Branches       6368     6382      +14     
============================================
+ Hits          25826    26004     +178     
- Misses        14879    14890      +11     
+ Partials       2860     2859       -1     
Impacted Files Coverage Δ Complexity Δ
...o/common/extension/support/ActivateComparator.java 73.68% <83.33%> (+0.60%) 0.00 <0.00> (ø)
...bo/rpc/cluster/support/FailbackClusterInvoker.java 52.45% <0.00%> (-18.04%) 0.00% <0.00%> (ø%)
...dubbo/remoting/exchange/support/DefaultFuture.java 80.34% <0.00%> (-6.84%) 0.00% <0.00%> (ø%)
.../apache/dubbo/remoting/transport/AbstractPeer.java 58.69% <0.00%> (-4.35%) 0.00% <0.00%> (ø%)
...he/dubbo/remoting/transport/netty/NettyServer.java 70.17% <0.00%> (-3.51%) 8.00% <0.00%> (-1.00%)
.../remoting/transport/netty4/NettyClientHandler.java 83.05% <0.00%> (-3.39%) 0.00% <0.00%> (ø%)
...ain/java/org/apache/dubbo/config/MethodConfig.java 95.65% <0.00%> (-3.09%) 0.00% <0.00%> (ø%)
...fig/configcenter/TreePathDynamicConfiguration.java 77.14% <0.00%> (-2.86%) 0.00% <0.00%> (ø%)
.../dubbo/monitor/support/AbstractMonitorFactory.java 78.37% <0.00%> (-2.71%) 0.00% <0.00%> (ø%)
...bo/registry/client/FileSystemServiceDiscovery.java 67.44% <0.00%> (-2.33%) 0.00% <0.00%> (ø%)
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e845e16...9916953. Read the comment docs.

@AlbumenJ AlbumenJ merged commit 1b53938 into apache:master May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants