Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless code in InjvmProtocolTest #7855

Merged
merged 2 commits into from
May 25, 2021

Conversation

xiaoheng1
Copy link
Contributor

What is the purpose of the change

Remove useless code in InjvmProtocolTest

see more detail from #7854

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2021

Codecov Report

Merging #7855 (660c550) into master (028153a) will decrease coverage by 0.35%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7855      +/-   ##
============================================
- Coverage     59.46%   59.11%   -0.36%     
  Complexity      555      555              
============================================
  Files          1086     1088       +2     
  Lines         43844    43854      +10     
  Branches       6399     6382      -17     
============================================
- Hits          26074    25926     -148     
- Misses        14885    15044     +159     
+ Partials       2885     2884       -1     
Impacted Files Coverage Δ
...a/org/apache/dubbo/rpc/filter/AccessLogFilter.java 28.35% <0.00%> (-50.75%) ⬇️
...va/org/apache/dubbo/rpc/support/AccessLogData.java 53.16% <0.00%> (-37.98%) ⬇️
...dubbo/common/status/support/LoadStatusChecker.java 46.15% <0.00%> (-15.39%) ⬇️
...rg/apache/dubbo/remoting/utils/PayloadDropper.java 76.92% <0.00%> (-15.39%) ⬇️
...ng/transport/dispatcher/WrappedChannelHandler.java 43.47% <0.00%> (-15.22%) ⬇️
...ng/transport/dispatcher/all/AllChannelHandler.java 68.96% <0.00%> (-13.80%) ⬇️
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 81.13% <0.00%> (-11.33%) ⬇️
...che/dubbo/remoting/transport/mina/MinaChannel.java 35.52% <0.00%> (-10.53%) ⬇️
...g/apache/dubbo/remoting/p2p/support/FileGroup.java 41.50% <0.00%> (-9.44%) ⬇️
...ting/exchange/support/header/HeartbeatHandler.java 83.72% <0.00%> (-9.31%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 028153a...660c550. Read the comment docs.

@AlbumenJ AlbumenJ merged commit 2dace54 into apache:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants