Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] Improve monitor creating, handle errors #7866

Merged
merged 1 commit into from
May 26, 2021

Conversation

kylixs
Copy link
Member

@kylixs kylixs commented May 26, 2021

What is the purpose of the change

Fix the problem that if an exception is thrown when creating a monitor, it is not handled correctly.

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@kylixs kylixs changed the title improve monitor creating, handle errors 3.0-improve monitor creating, handle errors May 26, 2021
@kylixs kylixs changed the title 3.0-improve monitor creating, handle errors [3.0]improve monitor creating, handle errors May 26, 2021
@kylixs kylixs changed the title [3.0]improve monitor creating, handle errors [3.0] Improve monitor creating, handle errors May 26, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 26, 2021

Codecov Report

Merging #7866 (b6ad94a) into 3.0 (dc54172) will decrease coverage by 0.11%.
The diff coverage is 70.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #7866      +/-   ##
============================================
- Coverage     58.68%   58.57%   -0.12%     
+ Complexity      326      325       -1     
============================================
  Files          1081     1081              
  Lines         43845    43838       -7     
  Branches       6535     6535              
============================================
- Hits          25730    25677      -53     
- Misses        15289    15323      +34     
- Partials       2826     2838      +12     
Impacted Files Coverage Δ
.../dubbo/monitor/support/AbstractMonitorFactory.java 80.00% <70.00%> (+1.62%) ⬆️
...apache/dubbo/registry/retry/AbstractRetryTask.java 58.33% <0.00%> (-13.89%) ⬇️
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 81.13% <0.00%> (-11.33%) ⬇️
...dubbo/remoting/exchange/support/DefaultFuture.java 85.47% <0.00%> (-7.70%) ⬇️
...he/dubbo/common/threadpool/ThreadlessExecutor.java 56.52% <0.00%> (-6.53%) ⬇️
...he/dubbo/common/config/CompositeConfiguration.java 67.39% <0.00%> (-4.35%) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 67.39% <0.00%> (-4.35%) ⬇️
...ng/transport/dispatcher/WrappedChannelHandler.java 63.04% <0.00%> (-4.35%) ⬇️
...he/dubbo/remoting/transport/netty/NettyServer.java 70.17% <0.00%> (-3.51%) ⬇️
...org/apache/dubbo/rpc/protocol/AbstractInvoker.java 58.33% <0.00%> (-3.13%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc54172...b6ad94a. Read the comment docs.

@AlbumenJ AlbumenJ merged commit 0fa05b8 into apache:3.0 May 26, 2021
@kylixs kylixs deleted the 3.0-improve-creating-monitor branch June 28, 2021 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants